Enabled test for extra tags in AppSecEvent report for Java#1635
Merged
ValentinZakharov merged 2 commits intomainfrom Sep 28, 2023
Merged
Enabled test for extra tags in AppSecEvent report for Java#1635ValentinZakharov merged 2 commits intomainfrom
ValentinZakharov merged 2 commits intomainfrom
Conversation
3229741 to
e97c63b
Compare
cbeauchesne
requested changes
Sep 28, 2023
|
|
||
| @coverage.basic | ||
| @bug(context.library >= "java@1.14.0", reason="APPSEC-11111") # released at 1.14.0, but bugged | ||
| @bug(context.library < "java@1.22.0", reason="APPSEC-11111") # released at 1.14.0, but bugged |
Collaborator
There was a problem hiding this comment.
Could you use manifest file, I presume that declaring it as relased at 1.22.0 with a comment be enough, and we keep the information in manifest file.
Collaborator
Author
There was a problem hiding this comment.
Thanks, fixed
e97c63b to
e13801c
Compare
cbeauchesne
approved these changes
Sep 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enabled test for extra tags in AppSecEvent report for Java.
Motivation
Missing functionality have been added in the Java tracer
See: APPSEC-11111
Workflow
Once your PR is reviewed, you can merge it! ❤️
Reviewer checklist
run-parametric-scenario,run-profiling-scenario...). If this PR modifies any system-tests internal, then add therun-all-scenarioslabel (more info).build-some-imagelabel is present