Skip to content

Enabled test for extra tags in AppSecEvent report for Java#1635

Merged
ValentinZakharov merged 2 commits intomainfrom
vzakhaorv/appsec_extra_tags
Sep 28, 2023
Merged

Enabled test for extra tags in AppSecEvent report for Java#1635
ValentinZakharov merged 2 commits intomainfrom
vzakhaorv/appsec_extra_tags

Conversation

@ValentinZakharov
Copy link
Copy Markdown
Collaborator

@ValentinZakharov ValentinZakharov commented Sep 28, 2023

Description

Enabled test for extra tags in AppSecEvent report for Java.

Motivation

Missing functionality have been added in the Java tracer
See: APPSEC-11111

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com
  • if a scenario is added (or removed), add (or remove) it in system-test-dasboard nightly

@ValentinZakharov ValentinZakharov requested review from a team as code owners September 28, 2023 15:16
@ValentinZakharov ValentinZakharov force-pushed the vzakhaorv/appsec_extra_tags branch from 3229741 to e97c63b Compare September 28, 2023 15:31
Comment thread tests/appsec/test_reports.py Outdated

@coverage.basic
@bug(context.library >= "java@1.14.0", reason="APPSEC-11111") # released at 1.14.0, but bugged
@bug(context.library < "java@1.22.0", reason="APPSEC-11111") # released at 1.14.0, but bugged
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use manifest file, I presume that declaring it as relased at 1.22.0 with a comment be enough, and we keep the information in manifest file.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants