Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions tests/appsec/test_reports.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,21 @@ def test_waf_eval_ms(self):
def test_no_overbudget(self):
""" There is no Appsec process over time budget """
interfaces.library.assert_metric_absence("_dd.appsec.waf_overtime_ms")


@skipif(not context.appsec_is_released, reason=context.appsec_not_released_reason)
@skipif(context.library == "java", reason="missing feature: response is not reported")
class Test_StatusCode(BaseTestCase):
def test_basic(self):
""" Appsec reports good status code """
r = self.weblog_get("/path_that_doesn't_exists/", headers={"User-Agent": "Arachni/v1"})
assert r.status_code == 404
interfaces.library.assert_waf_attack(r)

def check_http_code(event):
status_code = event["context"]["http"]["response"]["status"]
assert status_code == 404, f"404 should have been reported, not {status_code}"

return True

interfaces.library.add_appsec_validation(r, check_http_code)
8 changes: 0 additions & 8 deletions tests/appsec/waf/test_miscs.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,6 @@ def test_404(self):
address="server.request.headers.no_cookies",
)

def check_http_code(event):
status_code = event["context"]["http"]["response"]["status"]
assert status_code == 404, f"404 should have been reported, not {status_code}"

return True

interfaces.library.add_appsec_validation(r, check_http_code)


@skipif(not context.appsec_is_released, reason=context.appsec_not_released_reason)
class Test_MultipleHighlight(BaseTestCase):
Expand Down