Skip to content

[iast] Add Header Injection vulnerability exclusions for reflected headers#3408

Merged
CarlesDD merged 9 commits intomainfrom
ccapell/iast-header-exclusions
Nov 13, 2024
Merged

[iast] Add Header Injection vulnerability exclusions for reflected headers#3408
CarlesDD merged 9 commits intomainfrom
ccapell/iast-header-exclusions

Conversation

@CarlesDD
Copy link
Copy Markdown
Contributor

@CarlesDD CarlesDD commented Nov 7, 2024

Motivation

Check exclusions for Header Injection vulnerability for reflected headers

Changes

  • Created a new base test BaseTestHeaderInjectionReflectedExclusion
  • Added 4 new test, one for each exclusion
  • Updated manifests with missing_feature for all tracers except for Node.js
  • Created necessary endpoints for express4 and express4-typescript variants for Node.js

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

APPSEC-55563

@CarlesDD CarlesDD self-assigned this Nov 7, 2024

from utils import context, features, missing_feature
from ..utils import BaseSinkTest
from ..utils import BaseSinkTest, BaseTestHeaderInjectionReflectedExclusion
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BaseTestHeaderInjectionReflectedExclusion is Header related test, why are you creating the class in utils and not here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed :)

@CarlesDD CarlesDD changed the title [nodejs][iast] Add Header Injection vulnerability exclusions for reflected headers [iast] Add Header Injection vulnerability exclusions for reflected headers Nov 11, 2024
@CarlesDD CarlesDD marked this pull request as ready for review November 11, 2024 11:12
@CarlesDD CarlesDD requested review from a team as code owners November 11, 2024 11:12
@CarlesDD CarlesDD requested review from P403n1x87 and removed request for a team November 11, 2024 11:12
Comment thread tests/appsec/iast/sink/test_header_injection.py Outdated
@CarlesDD CarlesDD requested a review from cbeauchesne November 12, 2024 13:34
@CarlesDD CarlesDD merged commit 47612a6 into main Nov 13, 2024
@CarlesDD CarlesDD deleted the ccapell/iast-header-exclusions branch November 13, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants