[iast] Add Header Injection vulnerability exclusions for reflected headers#3408
Merged
[iast] Add Header Injection vulnerability exclusions for reflected headers#3408
Conversation
uurien
reviewed
Nov 8, 2024
|
|
||
| from utils import context, features, missing_feature | ||
| from ..utils import BaseSinkTest | ||
| from ..utils import BaseSinkTest, BaseTestHeaderInjectionReflectedExclusion |
Contributor
There was a problem hiding this comment.
BaseTestHeaderInjectionReflectedExclusion is Header related test, why are you creating the class in utils and not here?
uurien
approved these changes
Nov 11, 2024
robertomonteromiguel
requested changes
Nov 11, 2024
robertomonteromiguel
approved these changes
Nov 12, 2024
IlyasShabi
approved these changes
Nov 12, 2024
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Check exclusions for Header Injection vulnerability for reflected headers
Changes
BaseTestHeaderInjectionReflectedExclusionmissing_featurefor all tracers except for Node.jsexpress4andexpress4-typescriptvariants for Node.jsWorkflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is presentAPPSEC-55563