Skip to content

Update config_norm_rules.json for openai config#3833

Merged
sabrenner merged 1 commit intomainfrom
sabrenner/uodate-telemetry-openai-nodejs-config
Jan 16, 2025
Merged

Update config_norm_rules.json for openai config#3833
sabrenner merged 1 commit intomainfrom
sabrenner/uodate-telemetry-openai-nodejs-config

Conversation

@sabrenner
Copy link
Copy Markdown
Contributor

Motivation

These changes are in sync with changes made to dd-go in https://github.com/DataDog/dd-go/pull/165374.

Related PR for dd-trace-js: DataDog/dd-trace-js#5109

Changes

config_norm_rules.json for config telemetry test(s)

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@sabrenner sabrenner marked this pull request as ready for review January 15, 2025 21:40
@sabrenner sabrenner requested a review from a team as a code owner January 15, 2025 21:40
@sabrenner sabrenner merged commit 3c0bd23 into main Jan 16, 2025
@sabrenner sabrenner deleted the sabrenner/uodate-telemetry-openai-nodejs-config branch January 16, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants