[python] add test for suspicious import errors#3866
Merged
christophe-papazian merged 7 commits intomainfrom Jan 21, 2025
Merged
[python] add test for suspicious import errors#3866christophe-papazian merged 7 commits intomainfrom
christophe-papazian merged 7 commits intomainfrom
Conversation
cbeauchesne
approved these changes
Jan 21, 2025
Collaborator
cbeauchesne
left a comment
There was a problem hiding this comment.
Just two lines to remove, then all good
gnufede
approved these changes
Jan 21, 2025
robertomonteromiguel
pushed a commit
that referenced
this pull request
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
A suspicious import error was found in some system tests logs. This is related to a bad interaction between gevent and ctypes leading to an import failure when the appsec processor or the api manager is loaded.
This was fixed by DataDog/dd-trace-py#11987
As is seems to only be detectable through end to end test with a gunicorn based weblog, a system test was needed to add a regression test.
Changes
APPSEC-56449
Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present