Increase default debugger snapshot timeout from 10ms to 1s#5705
Merged
dd-mergequeue[bot] merged 1 commit intomainfrom Nov 14, 2025
Merged
Conversation
Contributor
|
|
watson
force-pushed
the
watson/DEBUG-4727/debugger-snapshot-time-budget
branch
from
b401721 to
a183565
Compare
watson
changed the title
Without this increase the tests would be flaky, as they are expecting to see a specific property with a specific value inside the collected snapshot. If the timeout occurred, that property might not be captured in the snapshot.
watson
force-pushed
the
watson/DEBUG-4727/debugger-snapshot-time-budget
branch
from
a183565 to
3b3583a
Compare
tylfin
approved these changes
Nov 13, 2025
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
dd-devflow
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-mergequeue
Bot
deleted the
watson/DEBUG-4727/debugger-snapshot-time-budget
branch
dd-devflow
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This is required in order for DataDog/dd-trace-js#6897 to land, so that the tests are not flaky.
Changes
Increase default debugger snapshot timeout from 10ms to 1s in the following scenarios:
debugger_pii_redactiontracing_config_nondefault_4Without this increase the tests would be flaky for Node.js, as they are expecting to see a specific property with a specific value inside the collected snapshot. If the timeout occurred, that property might not be captured in the snapshot.
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present