Skip to content

Update startup log tests to account for updated Node.js behavior #6513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bm1549 merged 7 commits into from
Mar 20, 2026
Merged

Update startup log tests to account for updated Node.js behavior #6513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7bbd4f9
System tests no longer require Node.js specific handling
bm1549 Mar 17, 2026
d2a023d
Merge branch 'main' into brian.marks/simplify-startup-log-test
bm1549 Mar 18, 2026
327818d
[node] enabled by default in 6.0.0
bm1549 Mar 18, 2026
3c2ee48
fix(nodejs): use >=6.0.0-0 to include prerelease versions in CI
bm1549 Mar 20, 2026
c2deea8
fix(nodejs): use >5.90.0 for readability per review feedback
bm1549 Mar 20, 2026
bceaa8d
Revert to >=6.0.0-0: >5.90.0 is wrong since future 5.x versions are u…
bm1549 Mar 20, 2026
50dd378
fix(nodejs): use >=6.0.0-pre for startup logs test
bm1549 Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion manifests/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ refs:
- &ref_5_87_0 '>=5.87.0' # Debugger: Capture expressions support
- &ref_5_89_0 '>=5.89.0'
- &ref_5_90_0 '>=5.90.0'
- &ref_6_0_0 '>=6.0.0-pre'
manifest:
tests/ai_guard/test_ai_guard_sdk.py::Test_ContentParts:
- weblog_declaration:
Expand Down Expand Up @@ -2076,7 +2077,7 @@ manifest:
tests/parametric/test_span_sampling.py::Test_Span_Sampling::test_keep_span_with_stats_computation_sss010: missing_feature (this has to be implemented by a lot of the tracers and we need to do a bit of work on the assert)
? tests/parametric/test_span_sampling.py::Test_Span_Sampling::test_root_span_selected_and_child_dropped_by_sss_when_dropping_policy_is_active016
: missing_feature (Not implemented)
tests/parametric/test_startup_logs.py::Test_Startup_Logs::test_startup_logs_default: missing_feature (Startup configuration log not emitted by default when DD_TRACE_STARTUP_LOGS is unset)
tests/parametric/test_startup_logs.py::Test_Startup_Logs::test_startup_logs_default: *ref_6_0_0
tests/parametric/test_startup_logs.py::Test_Startup_Logs::test_startup_logs_diagnostic_agent_unreachable: missing_feature (Diagnostic messages not emitted when agent is unreachable)
tests/parametric/test_telemetry.py::Test_Consistent_Configs: *ref_5_25_0
tests/parametric/test_telemetry.py::Test_Consistent_Configs::test_library_settings_2: missing_feature (Not implemented)
Expand Down
18 changes: 0 additions & 18 deletions tests/parametric/test_startup_logs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,6 @@ class Test_Startup_Logs:
def test_startup_logs_default(self, test_library: APMLibrary):
"""Verify default startup log behavior when DD_TRACE_STARTUP_LOGS is not set."""
with test_library:
# For Node.js, startup logs are emitted when the tracer tries to send its first trace
if context.library == "nodejs":
with test_library.dd_start_span("test_operation", service="test_service"):
pass
test_library.dd_flush()

logs = _get_startup_logs(test_library, required=True)

assert logs is not None
Expand All @@ -93,12 +87,6 @@ def test_startup_logs_default(self, test_library: APMLibrary):
def test_startup_logs_enabled(self, test_library: APMLibrary):
"""Verify startup logs are emitted when DD_TRACE_STARTUP_LOGS=true."""
with test_library:
# For Node.js, startup logs are emitted when the tracer tries to send its first trace
if context.library == "nodejs":
with test_library.dd_start_span("test_operation", service="test_service"):
pass
test_library.dd_flush()

logs = _get_startup_logs(test_library, required=True)

assert logs is not None
Expand All @@ -121,12 +109,6 @@ def test_startup_logs_enabled(self, test_library: APMLibrary):
def test_startup_logs_disabled(self, test_library: APMLibrary):
"""Verify startup logs are suppressed when DD_TRACE_STARTUP_LOGS=false."""
with test_library:
# For Node.js, trigger a trace to ensure startup logs would be emitted if enabled
if context.library == "nodejs":
with test_library.dd_start_span("test_operation", service="test_service"):
pass
test_library.dd_flush()

logs = _get_startup_logs(test_library, required=False)
if logs is not None:
match = re.search(STARTUP_LOG_PATTERN, logs, re.IGNORECASE)
Expand Down
Loading