Simpledfd Finder for less complex DFDs #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
#10 In ExampleModels has to be merged first |
Nicolas-Boltz
approved these changes
Sep 19, 2024
Member
Nicolas-Boltz
left a comment
Nicolas-Boltz
left a comment
There was a problem hiding this comment.
LGTM, but(!) the tests that check for a text of an exception are very error prone to evolution in the future. @01Parzival10 Maybe think about a refactoring that tests for something else? -> discussion for next week
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DFD TFG finder and logic for DFDs with number of assumptions that are verified