upgraded spec version and cargo file#204
Merged
ayushmishra2005 merged 8 commits intomasterfrom Jun 15, 2021
Merged
Conversation
cgroeschel
approved these changes
Jun 14, 2021
Collaborator
|
looks good, sorry laptop ran out of batteries. |
ltfschoen
requested changes
Jun 15, 2021
Collaborator
There was a problem hiding this comment.
- - i'd like to have this PR #205 reviewed and merged into this PR
- - if we or other users aren't able to use the chain specification or chain definition .json files (e.g. chain_def_local.json) that we've included in the chain-built folder, then they should be removed. PR #205 proposes to remove 'dev' and 'local' chain spec and def files
- - it should include an answer to this unanswered question https://github.com/DataHighway-DHX/node/pull/205/files#diff-eca12c0a30e25b4b46522ebf89465a03ba72a03f540796c979137931d8f92055R396
- - i'd also like us to try running the Harbour network using five nodes, and confirm that it generates and finalizes blocks, and that another user is able to connect to the running chain by following our documentation, which means that following the steps all these guides should work, otherwise we should update them
https://dev.datahighway.com/docs/en/tutorials/tutorials-nodes-full-node-setup
https://dev.datahighway.com/docs/en/tutorials/tutorials-nodes-validator-setup
https://github.com/DataHighway-DHX/node/blob/master/EXAMPLES.md#testnet-standalone-harbour-pos-with-multiple-nodes- - - and we should also try doing this step to check it all works, but only checking that it works on Harbour Testnet instead of Westlake Mainnet https://github.com/DataHighway-DHX/node/blob/master/EXAMPLES.md#mainnet-standalone-westlake-pos-with-multiple-nodes-
…ime_version docs: update docs with questions
ltfschoen
approved these changes
Jun 15, 2021
Collaborator
ltfschoen
left a comment
There was a problem hiding this comment.
propose to merge #204,
then check that this works on Harbour Testnet
https://dev.datahighway.com/docs/en/tutorials/tutorials-nodes-validator-setup
then release 3.0.5 when confirmed it works, otherwise do any fixes before release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.