Skip to content

fix idbreload issues #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonathonmcmurray merged 2 commits into from
Dec 19, 2024
Merged

fix idbreload issues #686

jonathonmcmurray merged 2 commits into from
Dec 19, 2024

Conversation

@michaelturkington
Copy link
Contributor

@michaelturkington michaelturkington commented Dec 4, 2024

Think I've understood the context here

  • wdb.q change simple enough, just using the local instead of the global variable
  • idb just cleaned up clients suggested conditional, removed their "1b" option to conform with original logic of the function.

@michaelturkington michaelturkington linked an issue Dec 4, 2024 that may be closed by this pull request
Client reported problems with idbreload #683
Closed
jonathonmcmurray
jonathonmcmurray reviewed Dec 5, 2024
View reviewed changes
@jonathonmcmurray jonathonmcmurray merged commit b3a76c0 into master Dec 19, 2024
@jonathonmcmurray jonathonmcmurray deleted the 683-client-reported-problems-with-idbreload branch December 19, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonathonmcmurray jonathonmcmurray jonathonmcmurray approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Client reported problems with idbreload

3 participants

@michaelturkington @jonathonmcmurray