Skip to content

Add subscriber info to CTP #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pmurphy979 merged 2 commits into from
Jan 7, 2025
Merged

Add subscriber info to CTP #687

pmurphy979 merged 2 commits into from
Jan 7, 2025

Conversation

@pmurphy979
Copy link
Contributor

@pmurphy979 pmurphy979 commented Dec 24, 2024 •
edited
Loading

Fixes #682

  • Added tptype, tablelist, and subdetails definitions to processes/chainedtp.q to mirror processes/segmentedtickerplant.q
  • Modified .ctp.sub to handle list of tables as first argument so it can be used in subdetails function. Behaviour is same as before if first argument is atomic. Could use .ctp.sub\: in subdetails instead, but that would duplicate the other dictionary entries being returned.
  • Added handling for tptype=`chained in .sub.subscribe
  • Added tests to check CTP subscription and log replay with/without a CTP log file

@pmurphy979 pmurphy979 marked this pull request as draft December 24, 2024 11:23
@pmurphy979 pmurphy979 marked this pull request as ready for review January 3, 2025 17:09
@pmurphy979 pmurphy979 merged commit 96359e6 into master Jan 7, 2025
@jonathonmcmurray jonathonmcmurray deleted the 682-subscription-to-standard-ctp-broken branch January 7, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonathonmcmurray jonathonmcmurray jonathonmcmurray approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Subscription to standard CTP broken

3 participants

@pmurphy979 @jonathonmcmurray