Merged
Conversation
betodealmeida
force-pushed
the
add_uuid_column_to_db
branch
from
876c8de to
569e725
Compare
samredai
approved these changes
Oct 28, 2022
youngman-droid
pushed a commit
to youngman-droid/dj
that referenced
this pull request
Aug 26, 2023
…_to_db feat: add UUID column to databases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a
uuidcolumn to databases and set a specific UUID for the special databases (DJ and SQLite).In a next PR, the uuid will be used in the API, replacing the id in requests, so we can get rid of ids -1 and 0 for the databases.
Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan