Update/client generic #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopenguin
requested review from
czirkelbach,
oeninghe-dataport and
warm-coolguy
as code owners
dopenguin
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The exported style file is now named
style.cssinsteadpolar-client.cssto be inline with documentation.Instructions for local reproduction and review
As we internally only use generic for the example pages:
npm run pages:buildPull Request Checklist (for Assignee)
[ ] Functionality has been tested on a smartphone[ ] Screenreader functionality has been manually tested with NVDAUI has been tested in the following tools regarding accessibility (only regarding functionality affected in this PR)
[ ] Chrome Lighthouse[ ] Firefox Accessibility