feat(reverseGeocoder): migrate plugin #423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oeninghe-dataport
requested review from
dopenguin and
warm-coolguy
as code owners
oeninghe-dataport
added
enhancement
oeninghe-dataport
force-pushed
the
vue3/migrate-plugin-reverse-geocoder
branch
from
07095a6 to
7d8eb98
Compare
# Conflicts: # package-lock.json
dopenguin
requested changes
Dec 16, 2025
Member
dopenguin
left a comment
dopenguin
left a comment
There was a problem hiding this comment.
Only made some slight suggestions, looks good overall!
Also, the implementation of indicateLoading seems reasonable.
Collaborator
Author
dopenguin
requested changes
Dec 16, 2025
Member
|
Just realized that I didn't check the functionality: 
EDIT: Note that this is unrelated to the implementation here but it seems like the service is currently not available. It works as expected tho. However, on start, I get the following error. My guess is, that the |
Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>
Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>
dopenguin
added a commit
that referenced
this pull request
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate plugin reverseGeocoder.
Instructions for local reproduction and review
console.logto the line after the call toreverseGeocodeUtilAdditional hints
Additional configurability is expected, but not yet implemented.
loadingIndicatoris connected similar tonotifyUserwhich differs from the requirements specification.It has to be discussed if this is acceptable.
Relevant tickets, issues, et cetera
Closes #350