Pull Request: Feature - Terminal Logic Implementation#14
Merged
Conversation
Construtors parameter changed from int to size_t, positive validation removed. getPageLength/ID now returns size_t, tests modified accordingly
Construtors parameter changed from int to size_t, tests modified accordingly
Construtors parameter changed from int to size_t, tests modified accordingly. Implemented move semantics, and equality operators
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR provides the full implementation for the
Terminalclass. It enables terminals to communicate through aRouter, manage incoming/outgoing traffic via dedicated buffers, and reconstruct original data pages from network packets.Changes Made
sendPageto handle page fragmentation using thenextPageIDsequence.processOutputBufferandprocessInputBufferto respect simulation cycle bandwidth (externalBWandinternalBW).findOrCreateReassemblerwith safety checks forpageIDandpageLength.handleCompletedPageto incrementreceivedPagescounter and cleanup resources.noexceptfor getters and setters to ensure performance and stability.toString()andoperator<<for easier simulation tracking.Related Issue
Closes # [Insert Issue Number Here]
Testing Performed
outputCapacityare correctly handled (dropped or partially enqueued).internalBWlimits the number of packets processed from the input buffer per tick.