Feat/router#16
Merged
Merged
Conversation
- Packet fields from int to size_t - Removed unnecessary field validations - Removed unnecessary tests
- Added an IP field for identification of the outputBuffers for routers and terminals - Added a new constructor with an ip parameter. - Implemented a getter for the IP - Added tests for new constructor and getter
- Added a size_t field for received packets. - Implemented a getter for receivedPackets - Validation of IP for a router and initialization of receivedPackets to zero - Count of receivedPackets in Terminal::receivePacket - Added an IP field and a constructor within MockRouter testing class - Added a ProcessOutputBuffer TEST
- Implemented struct Routes with two IPAddress fields - RoutingTable has a List<Routes> of entries - Implemented set/get for a specific IPAddress - Fully tested: SetEmptyTable, SetMultipleEntries, UpdateExistingEntry
- Uses std::unique_ptr to have the ownership of the terminals - Fully tested
- bool routePacket(Packet packet); to bool routePacket(Packet packet); - routerIsConnected and terminalIsConnected marked as nodiscard - use of stl algorithms in getNeighborBufferUsage, routerIsConnected and terminalIsConnected - RouterConnection initialization list
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TO DO