Feat/packetbuffer#10
Merged
Merged
Conversation
… and equality checks
…packet queues - test: add `PacketBufferTest` with comprehensive unit tests for `PacketBuffer` functionality
Closed
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
PacketBufferclass for managing packets in a FIFO queue, along with comprehensive unit tests for its functionality. Additionally, it expands the test coverage for thePageReassemblerclass by adding tests for slot validity and equality logic.New infrastructure: Packet buffer
PacketBufferclass inPacketBuffer.java, providing a generic bounded or unbounded FIFO queue forPacketobjects with methods for enqueue, dequeue, peek, capacity management, and buffer inspection.Test coverage improvements
PacketBufferTest.javawith thorough unit tests covering all buffer operations, edge cases, and error handling for the newPacketBufferclass.PageReassemblerTest.javato verifyhasPacketAt()returns correct results for valid and invalid slots, including out-of-bounds checks.PageReassemblerTest.javato ensureequals()returns false for instances with different page IDs, improving equality logic coverage.