Feat/reassembler#8
Merged
Merged
Conversation
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
PageReassemblerclass to the router simulator and provides comprehensive unit tests for its behavior. ThePageReassembleris responsible for collecting packets belonging to a single page, detecting when all packets have arrived, and assembling them into a complete page. The tests cover all key aspects of its functionality and edge cases.Core functionality:
Page reassembly and management
PageReassemblerclass, which tracks packets for a specific page, manages their positions, detects completion, and assembles the page when all packets are received. Includes expiry logic based on simulation ticks. (src/main/java/ar/edu/unc/david/routersimulator/service/PageReassembler.java)Testing and validation:
Unit tests for correctness
PageReassemblerTestwith thorough coverage, including constructor validation, packet addition and rejection, completion detection, expiry checks, equality, hash code, and string representation. (src/test/java/ar/edu/unc/david/routersimulator/service/PageReassemblerTest.java)