Skip to content

Hamburger menu#3

Open
David-Verde wants to merge 7 commits intoMasterfrom
hamburger-menu
Open

Hamburger menu#3
David-Verde wants to merge 7 commits intoMasterfrom
hamburger-menu

Conversation

@David-Verde
Copy link
Owner

@David-Verde David-Verde commented May 9, 2022

Add changes to the hamburger button
Add font sizes and padding in the contact form
and add changes to the readme file.
fix the close x button in the hamburger

@David-Verde
Copy link
Owner Author

so sorry, I did not know my repository is in private, so the changes my previewer sent to me did not save in my repository and I only have one more chance :( please do not take me the last chance because I don't know what are the changes I need to make

Copy link

@sja-thedude sja-thedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid Code Review Request ❌

Hi @Unyielding1, This is @sja-thedude your code reviewer.

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

You have submitted a project, that doesn't have a description, kindly add a description of what all changes are made here and commits are not from both the partners. This is a pair programming project and requires commits from both the partners in the group.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Don't worry I have checked your project it's perfect. It will get approved. just make sure to do the required changes, if need help do contact me. 😄

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Copy link

@zieeco zieeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

status: APPROVED 🟢 💯

Hi, @Team

68747470733a2f2f6d656469612e67697068792e636f6d2f6d656469612f78543078657a514755357843444a754350652f67697068792e676966

Good job so far 👍 Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights ⚡

✅ Descriptive PR 👍
✅ Nice design 🔥
✅ Linters are passing 👏

Optional suggestions

  • Add cursor: pointer to the cancel button and increase the size.
  • Add spaces to indicate the end of a function to make your codebase more readable.

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants