Summand and Module clean up part 1#55
Merged
DavidLapous merged 8 commits intoDavidLapous:mainfrom Mar 5, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I extracted
SummandandModulefromapproximation.hto clean it up a bit and also remove unused methods. But I would also like to replace all nested vector outputs with flat vector outputs, to avoid copies at cython level (when possible). But before doing so, I would like to have the new changes validated as it is already a lot.So @DavidLapous, I would like you to look at the following points:
MultiDiagram*classes (we decided to get rid of) first.I also added
set_target_properties(${target_name} PROPERTIES COMPILE_FLAGS "--no-warnings")for all external libraries, to find more easily compilation problems when they occur.