Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I am flattening the outputs of
SummandandModule, I added a method to move a cythonvector[]to a numpy array without copying and with something equivalent to ownership transfer, i.e. the result is the same thanres = numpy.asarray(<dtype[:a, :b]>(vec.data()))but such thatreswill remain valid aftervecis destroyed andveclooses access to the data to avoid accidents.I tested it for the plottings and it seems to work. As I won't be working on this for at least 3 weeks, I thought I should make a PR out of it before finishing with
SummandandModulesuch that, in the mean time, @DavidLapous can play with it on other class/methods if he wants.