This repository was archived by the owner on Apr 2, 2026. It is now read-only.
Fix 100% CPU usage by removing busy loop#2
Open
mrnugget wants to merge 3 commits intoDazWilkin:masterfrom
Open
Fix 100% CPU usage by removing busy loop#2mrnugget wants to merge 3 commits intoDazWilkin:masterfrom
mrnugget wants to merge 3 commits intoDazWilkin:masterfrom
Conversation
Author
|
Update: it seems like this might break something, because values are not being published anymore. I'll take a look. |
Author
|
Using the waitgroup, as in the f8d289d, fixes it and now there's barely any CPU usage. |
janisz
approved these changes
Jun 10, 2021
| // Loop forever while notification handler respond | ||
| wg := sync.WaitGroup{} | ||
| wg.Add(1) | ||
| for { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous loop was pinning a CPU completely. CPU usage was 100% of a single core.
With this loop though, the Go scheduler knows not to run it all the time. There are a ton of other ways to not have a busy loop, but this seems easiest.