Skip to content

C++17 and reduce Boost usage#701

Closed
Bushstar wants to merge 28 commits into
v3from
move-to-c++17
Closed

C++17 and reduce Boost usage#701
Bushstar wants to merge 28 commits into
v3from
move-to-c++17

Conversation

@Bushstar
Copy link
Copy Markdown
Contributor

@Bushstar Bushstar commented Aug 31, 2021 •
edited
Loading

bvbfan
bvbfan previously approved these changes Aug 31, 2021
View reviewed changes
@bvbfan
Copy link
Copy Markdown
Contributor

bvbfan commented Aug 31, 2021

In addition we can remove optional.h, boost::optional/Optional -> std::optional, boost::scoped_ptr -> std::unique_ptr, boost::shared_ptr -> std::shared_ptr, boost::variant -> std::variant

@Bushstar Bushstar changed the title [WIP] C++17 [WIP] C++17 and reduce Boost usage Aug 31, 2021
@Bushstar Bushstar force-pushed the move-to-c++17 branch 2 times, most recently from 57771db to 420ac4d Compare September 1, 2021 07:24
@Bushstar Bushstar changed the title [WIP] C++17 and reduce Boost usage C++17 and reduce Boost usage Sep 9, 2021
@bvbfan
Copy link
Copy Markdown
Contributor

bvbfan commented Sep 10, 2021

boost filesystem -> std filesystem, i'm pretty sure it has some difference between.

@Bushstar
Copy link
Copy Markdown
Contributor Author

Bushstar commented Sep 10, 2021

@bvbfan Removing Boost Filesystem is currently a WIP upstream, let's leave them to do the hard work and follow suit once done.

bitcoin/bitcoin#20744

@bvbfan
Copy link
Copy Markdown
Contributor

bvbfan commented Sep 10, 2021 •
edited
Loading

So that's it, you can move it (means this PR to master) ?

@Bushstar
Copy link
Copy Markdown
Contributor Author

Bushstar commented Sep 10, 2021

It is to master, but we will not look to merge until after loans for which I'll have to update this PR as loans uses a lot of removed Boost. I'm still checking some other uses of Boost that we introduced.

@bvbfan bvbfan requested review from bvbfan and removed request for ShengguangXiao November 8, 2021 07:04
@Bushstar Bushstar changed the base branch from master to v3 November 8, 2021 07:07
@prasannavl prasannavl added this to the 3.0.0 - Great World milestone Dec 20, 2021
@prasannavl
Copy link
Copy Markdown
Contributor

prasannavl commented Mar 9, 2022 •
edited
Loading

Closing, since these are already in v3 branch.

@prasannavl prasannavl closed this Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mixa84 Mixa84 Awaiting requested review from Mixa84

@monstrobishi monstrobishi Awaiting requested review from monstrobishi

@surangap surangap Awaiting requested review from surangap

@uzyn uzyn Awaiting requested review from uzyn

@fuxingloh fuxingloh Awaiting requested review from fuxingloh

1 more reviewer

@bvbfan bvbfan bvbfan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Bushstar Bushstar

Labels

None yet

Projects

None yet

Milestone

Next Sprint(s)

Development

Successfully merging this pull request may close these issues.

5 participants

@Bushstar @bvbfan @prasannavl @defichain-bot @dcorral