-
Notifications
You must be signed in to change notification settings - Fork 15
Tria updates #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Tria updates #102
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
==========================================
+ Coverage 44.53% 47.02% +2.48%
==========================================
Files 15 15
Lines 2746 2856 +110
Branches 348 368 +20
==========================================
+ Hits 1223 1343 +120
+ Misses 1401 1377 -24
- Partials 122 136 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request introduces several enhancements to the LaPy mesh processing library, focusing on critical point detection, level set extraction, and polygon handling. The changes add new functionality for identifying topological features (minima, maxima, saddles) on triangle meshes and improve the handling of level set curves, particularly closed loops.
Changes:
- Added
critical_points()method to identify extrema and saddle points on mesh surfaces - Enhanced
Polygonclass with auto-detection of closed loops when first/last points are identical - Refactored
__reduce_edges_to_path()to handle multiple disconnected components and closed loops - Added
extract_level_paths()method to extract multiple level set components as Polygon objects with metadata - Updated
level_path()to useextract_level_paths()internally for consistency
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 11 comments.
| File | Description |
|---|---|
| lapy/polygon.py | Added optional closed parameter with auto-detection logic that removes duplicate endpoints |
| lapy/tria_mesh.py | Added is_boundary(), critical_points(), and extract_level_paths() methods; refactored __reduce_edges_to_path() to handle multiple components and closed loops; updated level_path() implementation |
| lapy/utils/tests/test_tria_mesh.py | Added comprehensive tests for critical_points, extract_level_paths, and level_path with various edge cases including closed loops and multiple components |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.