Coverage/issue 124

[dronefreak]

Pull Request

Description

Type of Change

• 🐛 Bug fix (non-breaking change which fixes an issue)
• ✨ New feature (non-breaking change which adds functionality)
• 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
• 📚 Documentation update
• ⚡ Performance improvement
• 🧹 Code refactoring
• 🧪 Test addition or update
• 🔧 Configuration change
• 🧬 Bioinformatics enhancement
• 🔄 Workflow improvement

Component

• Core Workflow Engine
• PRIME Flow (Protein Engineering)
• Bioinformatics Flow (Data Fusion)
• DeepSearch Flow (Web Research)
• Challenge Flow (Experimental)
• Tool Registry
• Agent System
• Configuration (Hydra)
• Pydantic Graph
• Documentation
• Tests
• Other:

Related Issues

• Fixes #
• Closes #
• Related to #

Changes Made

• Added tests for DeepResearch/src/statemachines/workflow_pattern_statemachines.py
• Current coverage 97%

Testing

• I have tested these changes locally
• I have added/updated tests for my changes
• All existing tests pass
• I have tested with different configurations
• I have tested with different flows (PRIME, Bioinformatics, DeepSearch, etc.)

Test Configuration

# Example test command
uv run deepresearch question="..." app_mode=single_react

Configuration Changes

• No configuration changes
• Added new configuration options
• Modified existing configuration
• Removed configuration options

Configuration Details

# Example configuration changes
flows:
  new_flow:
    enabled: true
    params:
      new_param: "value"

Documentation

• No documentation changes needed
• Updated README
• Updated API documentation
• Updated configuration documentation
• Added code comments
• Updated examples

Performance Impact

• No performance impact
• Performance improvement
• Performance regression (explain below)

Performance Details

• Execution time:
• Memory usage:
• Other metrics:

Breaking Changes

• No breaking changes
• Breaking change (describe below)

Migration Guide

Checklist

• My code follows the project's style guidelines
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published

Additional Notes

Please note that the current coverage for the DeepResearch/src/statemachines/workflow_pattern_statemachines.py is only 97% as there are certain functions that are BROKEN! Yes, in particular the following ones below:

create_collaborative_pattern_graph()
create_sequential_pattern_graph()
create_hierarchical_pattern_graph()

Simply importing them to create a Graph creates an error with the following traceback:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
    import platform
  File "/home/saumya.saksena/projects/DeepCritical/DeepResearch/src/statemachines/workflow_pattern_statemachines.py", line 611, in create_collaborative_pattern_graph
    return Graph(
        nodes=[
    ...<8 lines>...
        state_type=WorkflowPatternState,
    )
  File "/home/saumya.saksena/projects/DeepCritical/.venv/lib/python3.13/site-packages/pydantic_graph/graph.py", line 104, in __init__
    self._validate_edges()
    ~~~~~~~~~~~~~~~~~~~~^^
  File "/home/saumya.saksena/projects/DeepCritical/.venv/lib/python3.13/site-packages/pydantic_graph/graph.py", line 516, in _validate_edges
    raise exceptions.GraphSetupError(f'{bad_edges_list[0]} but not included in the graph.')
pydantic_graph.exceptions.GraphSetupError: `ExecutePattern` is referenced by `SetupAgents` but not included in the graph.

I did not yet look into fixing it myself, but this could be done in priority next.

Screenshots/Output

Before

After

Reviewer Notes

[Josephrp]

looks absolutely fantastic , i deeply appreciate these contributions , i hope you know !

reviewing this code is inspiring me to make a "validator" for these graphs maybe it could be smart and useful tool to make (after)

[dronefreak]

Hi @Josephrp thank you for your kind words, means a lot to me!

I am just glad that I have been of some use to you. I hope to be able to continue this in the future.

Regarding the PR, I see that the merging is blocked due to unverified signatures on the commits? Is there something to be done on my side? I am not familiar with this auto-merge process.