fix: remove misleading @defer decorator comments#36
Merged
Josephrp merged 2 commits intoDeepCritical:devfrom Oct 6, 2025
MarioAderman:fix/issue-2-remove-defer-decorator
Merged
fix: remove misleading @defer decorator comments#36Josephrp merged 2 commits intoDeepCritical:devfrom MarioAderman:fix/issue-2-remove-defer-decorator
Josephrp merged 2 commits intoDeepCritical:devfrom
MarioAderman:fix/issue-2-remove-defer-decorator
Conversation
Removes all references to non-existent @defer decorator from codebase. The @defer decorator never existed in Pydantic AI. Tools are correctly implemented using standard Pydantic AI patterns. Changes: - Removed 16 @defer comments from tool files - Updated README Known Issues section - All tools continue to work correctly (no functional changes) Fixes #2
Signed-off-by: marioaderman <108372419+MarioAderman@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Josephrp
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes all misleading references to non-existent
@deferdecorator from the codebase. Neitherpydantic_ainorpydantic_graphuses the so-called decorator. For simplicity's sake references were removed.Type of Change
Component
Related Issues
Changes Made
@defercomments fromDeepResearch/src/tools/deep_agent_tools.py@defercomments fromDeepResearch/src/tools/bioinformatics_tools.pyREADME.mdTesting
Test Configuration
Configuration Changes
Documentation
Performance Impact
Zero functional changes - only misleading documentation removed.
Breaking Changes
Checklist
Additional Notes
Investigation Summary
Key Finding: The
@deferdecorator NEVER existed in Pydantic AI (verified across all versions).Screenshots/Output
Before
After
Reviewer Notes
This PR only removes misleading documentation. No functional code changes were made. All tools continue to work correctly as they were already implemented using proper Pydantic AI patterns.