feat(P3): Epic 3.1 — SkillVersion, ValidationError, validate() methods [EPIC 3.1]#12
Merged
Deepfreezechill merged 2 commits intomainfrom Apr 2, 2026
Merged
Conversation
…to skill types - Add SkillVersion frozen dataclass: semantic versioning with parse(), compare, bump_patch/minor/major, and serialization (to_dict/from_dict) - Add ValidationError exception class for schema validation failures - Add validate() to SkillLineage: enforces origin-to-parent rules (IMPORTED/CAPTURED=0 parents, FIXED=1, DERIVED=1+), generation >= 0 - Add validate() to SkillJudgment: non-empty skill_id - Add validate() to EvolutionSuggestion: target count rules per evolution type - Add validate() to ExecutionAnalysis: non-empty task_id - Add validate() to SkillRecord: non-empty id/name, counter invariants (non-negative, applied<=selections, completions<=applied), cascades to lineage - Export SkillVersion and ValidationError from skill_engine __init__ - Add 99 tests in test_skill_types.py covering all types, enums, validation, serialization round-trips, edge cases, and boundary conditions Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🔒 Phase Gate Enforcement — 🚫 FAIL
Verdict: FAIL
|
…on, recursion - F1: SkillVersion default minor=0 (was 1), from_dict default minor=0 - F2: Store._upsert() and _insert_analysis() call validate() before SQL - F3: Type coercion (int/str) in from_dict for SkillVersion, SkillRecord, ExecutionAnalysis with TypeError/ValueError → ValidationError - F4: Recursive validation: ExecutionAnalysis validates judgments/suggestions, SkillRecord guards lineage None check - F5: 16 hostile-input tests (wrong types, partial payloads, adversarial values) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
VonkraLLC
approved these changes
Apr 2, 2026
VonkraLLC
left a comment
VonkraLLC
left a comment
There was a problem hiding this comment.
Approved: /8eyes R2 — all 5 findings fixed. 1142 tests passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add SkillVersion dataclass, ValidationError exception, and validate() methods to all skill engine types.
Closes #11
Changes