feat(P3): Epic 3.3 — LineageTracker extraction from SkillStore#17
Merged
Deepfreezechill merged 2 commits intomainfrom Apr 2, 2026
Merged
feat(P3): Epic 3.3 — LineageTracker extraction from SkillStore#17Deepfreezechill merged 2 commits intomainfrom
Deepfreezechill merged 2 commits intomainfrom
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🔒 Phase Gate Enforcement — 🚫 FAIL
Verdict: FAIL
|
…-conn, layering - Fix 1: get_ancestors() cycle bug — seed visited with starting skill_id to prevent cycles - Fix 2: get_lineage_tree() diamond DAG — pass copy of visited to each sibling subtree to preserve all paths - Fix 3: shared-conn _reader() dirty reads — acquire lock when using shared connection - Fix 4: SkillRepository._to_record layering violation — make public as to_record() - Fix 5: recent_analyses hydration regression — re-hydrate in SkillStore delegation methods - Fix 6: missing test coverage — add cycle, diamond, shared-conn isolation, and facade tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
VonkraLLC
approved these changes
Apr 2, 2026
VonkraLLC
left a comment
VonkraLLC
left a comment
There was a problem hiding this comment.
LGTM — /8eyes R1 findings addressed: cycle bug, diamond DAG, shared-conn reads, layering, hydration, tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Epic 3.3: LineageTracker Extraction
What
Extracts lineage/parent-child tracking from the monolithic SkillStore into a focused LineageTracker class.
Changes
Results
Closes #16