chore(P3): eliminate all actionable warnings + thread-safe close()#27
Merged
Deepfreezechill merged 1 commit intomainfrom Apr 3, 2026
Merged
chore(P3): eliminate all actionable warnings + thread-safe close()#27Deepfreezechill merged 1 commit intomainfrom
Deepfreezechill merged 1 commit intomainfrom
Conversation
Warning cleanup (54 → 44, remaining are P4 architecture file-size): - DeprecationWarning: wrap set_schema_version tests with deprecated_call() - ResourceWarning: atexit cleanup for mcp_server file handles - RuntimeWarning: MagicMock for sync is_initialized() (was AsyncMock) Thread safety: - MigrationManager.close(): _closed + _conn.close() both under mutex - Eliminates TOCTOU race window Test hygiene: - Architecture boundary allowlist updated for mcp_server.py line shifts - 31 skipped tests audited: 8 Windows/symlink, 23 missing deps (all valid) Verified by 3-agent adversarial review (OOP v4.2.0): - /8eyes (Opus 4.6): SHIP 0.95 — 5/5 attacks repelled - /collab (GPT-5.4): SHIP after close() TOCTOU fix - code-review (Sonnet): APPROVED 1,351 tests passing, 44 warnings (all P4 architecture scope). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🔒 Phase Gate Enforcement — 🚫 FAIL
Verdict: FAIL
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning Cleanup
Eliminates all actionable warnings from test suite (54 → 44 remaining, all P4 architecture scope).
Thread Safety
Test Hygiene
/8eyes + /collab Buyoff
1,351 tests passing.