P3 Final: Batch hydration, mypy fixes, hydration regression#28
Merged
Deepfreezechill merged 1 commit intomainfrom Apr 3, 2026
Merged
P3 Final: Batch hydration, mypy fixes, hydration regression#28Deepfreezechill merged 1 commit intomainfrom
Deepfreezechill merged 1 commit intomainfrom
Conversation
- Rewrite _hydrate_records() from O(N) per-record to O(1) batched queries - Add TagSearch.get_tags_batch() for bulk tag retrieval - Add AnalysisStore.batch_load_recent_analyses() with ROW_NUMBER window fn - Refactor _to_analysis() to accept preloaded judgments (backward compat) - Fix 3 mypy errors: assert lastrowid, List[Any] params typing - Fix hydration regression: get_versions/get_ancestry/load_by_category - Add _hydrate_record()/_hydrate_records() facade helpers - Fix check_same_thread via _make_connection(), max_depth clamp to 50 - Fix docstring drift, MigrationManager doc references - 4 new hydration regression tests in test_facade_coverage.py /8eyes R3: SHIP 0.95 (Opus 4.6) — 5/5 outcomes pass, 4 attacks repelled /collab R3: SHIP 0.93 (GPT-5.4) — 5/5 checks pass, 4 attacks repelled Suite: 1,356 passed, 31 skipped, 44 warnings (all P4 file-size) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🔒 Phase Gate Enforcement — 🚫 FAIL
Verdict: FAIL
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all R2 blockers from /8eyes and /collab review rounds.
Changes (6 files, +580/-27)
Review Verdicts
Test Results
\
1,356 passed, 31 skipped, 44 warnings in 37.83s
\\
P4 Advisory