api errors 4xx and 5xx should be distinguished

[thomas-riccardi]

Currently all API errors (4xx and 5xx) are exposed identically: BadStatus

deepomatic-client-python/deepomatic/http_helper.py

Lines 185 to 186 in 3640bec

	if response.status_code < 200 or response.status_code >= 300:
	raise BadStatus(response)

We should at least distinguish between 4xx and 5xx. Later we could do some retry on 5xx, cf #17

[maingoh]

The user can retrieve the status with exc.status_code

[thomas-riccardi]

OK.
Using inference() makes it hard though, as the wait() is done there transparently, and the exception bypasses all that.
So we could re-qualify the issue to support 5xx retries in wait().

[vdel]

+1

I had issue with that

[vdel]

What about splitting BadStatus into BadRequest and ServerError ?
Getting rid of BadStatus will allow to spot places where the BadStatus is caught in the code that uses this client, in order to take correct actions. We will need to bump to the next version, like 0.9 as we will break the compatibility.

[maingoh]

This could be ClientError instead of BadRequest (Only corresponding to 400 status code)

[vdel]

This could be ClientError instead of BadRequest (Only corresponding to 400 status code)

Indeed