-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
breaking changeSemVer Major: breaking changeSemVer Major: breaking changedifficulty/easyEasy issue (less than one day)Easy issue (less than one day)enhancementkind/stabilityImpact the reliability/stability of the codeImpact the reliability/stability of the codepriority/lowIssue to solve at some pointIssue to solve at some point
Description
Currently TaskError and TaskTimeout take Task.data() (dict) as constructor argument.
This could be changed to taking the full Task object.
Pros:
- everything on these Exceptions is already named
task, but it's only data tasks for now (unexpectedly): it would respect the "least surprise principle". - we would have normalized access to the failed task when handling exceptions
- it would make it easier to control how everything is displayed (
__str__) (avoid duplicates effort, normalize)
Cons:
- in some cases (Task never refreshed, can happen when API is down), accessing
Taskfields lazy loads data from API, this would be unexpected when handling an error (and could create errors during errors (+ the long auto retry))
Metadata
Metadata
Assignees
Labels
breaking changeSemVer Major: breaking changeSemVer Major: breaking changedifficulty/easyEasy issue (less than one day)Easy issue (less than one day)enhancementkind/stabilityImpact the reliability/stability of the codeImpact the reliability/stability of the codepriority/lowIssue to solve at some pointIssue to solve at some point