Skip to content

Better HTTP User-Agent: deepomatic-api-python-client #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomas-riccardi merged 1 commit into from
May 20, 2019
Merged

Better HTTP User-Agent: deepomatic-api-python-client #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deepomatic/api/http_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def __init__(self, app_id=None, api_key=None, verify_ssl=None, host=None, versio
else:
self.user_agent = ''

self.user_agent += '{package_title}/{package_version} requests/{requests_version} python/{python_version} platform/{platform}\
self.user_agent += '{package_title}-python-client/{package_version} requests/{requests_version} python/{python_version} platform/{platform}\
'.format(**user_agent_params)

if user_agent_suffix:
Expand Down
2 changes: 1 addition & 1 deletion tests/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ class TestClient(object):
def test_headers(self, client):
http_helper = client.http_helper
session_headers = http_helper.session.headers
assert session_headers['User-Agent'].startswith('{}-tests/{} {}/{}'.format(__title__, __version__, __title__, __version__))
assert session_headers['User-Agent'].startswith('{}-tests/{} {}-python-client/{}'.format(__title__, __version__, __title__, __version__))
assert 'platform/' in session_headers['User-Agent']
assert 'python/' in session_headers['User-Agent']
assert session_headers['X-APP-ID']
Expand Down