Skip to content

Cleanup: more HTTPRetry default parameters in HTTPRetry.Default #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomas-riccardi merged 1 commit into from
Oct 3, 2019
Merged

Cleanup: more HTTPRetry default parameters in HTTPRetry.Default #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions deepomatic/api/http_retry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,15 @@ class HTTPRetry(object):
wait_fixed(0.1) + random_wait)
```
:type wait: tenacity.wait_base
:param stop (optional). Tell when to stop retrying. By default it stops retrying after a delay of 60 seconds.
:param stop (optional). Tell when to stop retrying. By default it stops retrying after 60s (Default.RETRY_TIMEOUT).
A last retry can be done just before this delay is reached, thus the total amount of elapsed time might be a bit higher.
More details in tenacity source code https://github.com/jd/tenacity/blob/5.1.1/tenacity/stop.py
Raises tenacity.RetryError when timeout is reached.
:type timeout: tenacity.stop_base
"""

class Default(object):
RETRY_TIMEOUT = 60
RETRY_EXP_MAX = 10.
RETRY_EXP_MULTIPLIER = 0.5
RETRY_STATUS_CODES = [500, 502, 503, 504]
Expand All @@ -65,7 +66,7 @@ def __init__(self, retry_if=None, wait=None, stop=None):
self.stop = stop

if self.stop is None:
self.stop = stop_after_delay(60)
self.stop = stop_after_delay(HTTPRetry.Default.RETRY_TIMEOUT)

if self.retry_if is None:
self.retry_status_code = set(HTTPRetry.Default.RETRY_STATUS_CODES)
Expand Down