Fix timeout exception on Network create #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-riccardi
force-pushed
the
hotfix-77-network_upload_timeout
branch
from
7bbe5d6 to
ff2dae7
Compare
maingoh
approved these changes
Nov 14, 2019
| FAST = (3.05, 10.) | ||
| MEDIUM = (3.05, 60.) | ||
| SLOW = (3.05, 600.) | ||
| FAST = 8. |
Contributor
There was a problem hiding this comment.
Don't we want to put your explanations as code comment ?
In fact `requests` `connect` timeout is *not* just TCP connect, but also includes sending the whole HTTP request, which can be much longer than 3s for Network uploads. Before the issue is fixed in `requests` we should not fail long uploads: stop using advanced timeouts for now. Also decreased FAST timeout from 10 to 8 so we are guaranteed to have at least 3 tries with the 60s timeout on tasks GET loop.
thomas-riccardi
force-pushed
the
hotfix-77-network_upload_timeout
branch
from
ff2dae7 to
ee693b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #77
In fact
requestsconnecttimeout is not just TCP connect, butalso includes sending the whole HTTP request, which can be much
longer than 3s for Network uploads.
Before the issue is fixed in
requestswe should not fail longuploads: stop using advanced timeouts for now.
Also decreased FAST timeout from 10 to 8 so we are guaranteed to have
at least 3 tries with the 60s timeout on tasks GET loop.