Skip to content

Don't push docker images and don't push git tag in DMAKE_K8S_DRY_RUN=1 mode #507

@thomas-riccardi

Description

@thomas-riccardi

It is both useless and dangerous:

When deploying locally the docker image tag is always the same for a given branch, so it effectively overwrites an image that is used in the remote env, and it may be unexpectedly applied on the next pod creation (for example during a nodepool upgrade).

When using dry-run mode we expect no remote state change at all.

Same issue for the final git tag push.

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issuekind/bugsize/XSDenotes a PR that changes 0-9 lines, ignoring generated files.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions