Skip to content

Add more logs to the client#239

Merged
t-aleksander merged 4 commits into
devfrom
add-more-logs
Jun 18, 2024
Merged

Add more logs to the client#239
t-aleksander merged 4 commits into
devfrom
add-more-logs

Conversation

@t-aleksander
Copy link
Copy Markdown
Contributor

@t-aleksander t-aleksander commented Jun 13, 2024

📖 Description

  • adds more details to some logs
  • adds more logging (info, debug, etc.)
  • adds required error message to the otherwise a bit vague "internal error" error type

closes #206

All related PRs:
#239
DefGuard/defguard#645
DefGuard/gateway#98

🛠️ Dev Branch Merge Checklist:

Documentation

  • If testing requires changes in the environment or deployment, please update the documentation (https://defguard.gitbook.io) first and attach the link to the documentation section in this pool request
  • I have commented on my code, particularly in hard-to-understand areas

Testing

  • I have performed manual tests manually and all changes work
  • New and existing unit tests pass locally with my changes

🏚️ Main Branch Merge Checklist:

Testing

  • I have merged my changes before to dev and the dev checklist is done
  • I have tested all functionalities on the dev instance and they work

Documentation

  • I have made corresponding changes to the user & admin documentation and added new features documentation with screenshots for users/admins

@t-aleksander t-aleksander self-assigned this Jun 13, 2024
Comment thread src-tauri/src/commands.rs Outdated
Comment thread src-tauri/src/service/log_watcher.rs Outdated
Comment thread src-tauri/src/utils.rs Outdated
Comment thread src-tauri/src/utils.rs Outdated
Comment thread src-tauri/src/utils.rs Outdated
Comment thread src-tauri/src/utils.rs Outdated
Comment thread src-tauri/src/utils.rs Outdated
Comment thread src-tauri/src/utils.rs Outdated
@t-aleksander t-aleksander marked this pull request as ready for review June 18, 2024 07:23
@t-aleksander t-aleksander merged commit c70d9e5 into dev Jun 18, 2024
@t-aleksander t-aleksander deleted the add-more-logs branch June 18, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants