Avoid HTTP return code: 204 No Content

crates/defguard_core/src/db/models/biometric_auth.rs

@@ -29,6 +29,7 @@ pub struct BiometricAuth<I = NoId> {
 }
 
 impl BiometricAuth {
+    #[must_use]
     pub fn new(device_id: Id, pub_key: String) -> Self {
         Self {
             id: NoId,
@@ -80,8 +81,8 @@ impl BiometricChallenge {
         }
         let challenge = gen_alphanumeric(44);
         Ok(Self {
-            challenge,
             auth_pub_key,
+            challenge,
         })
     }
 

crates/defguard_core/src/db/models/mod.rs

@@ -86,6 +86,7 @@ pub struct GroupDiff {
 }
 
 impl GroupDiff {
+    #[must_use]
     pub fn changed(&self) -> bool {
         !self.added.is_empty() || !self.removed.is_empty()
     }

crates/defguard_core/src/db/models/settings.rs

@@ -326,6 +326,7 @@ impl Settings {
             && self.smtp_sender != Some(String::new())
     }
 
+    #[must_use]
     pub fn ldap_using_username_as_rdn(&self) -> bool {
         self.ldap_user_rdn_attr
             .as_deref()

crates/defguard_core/src/db/models/wireguard.rs

@@ -509,13 +509,15 @@ impl WireguardNetwork<Id> {
     }
 
     /// Checks if all device addresses are contained in at least one of the network addresses
+    #[must_use]
     pub fn contains_all(&self, addresses: &[IpAddr]) -> bool {
         addresses
             .iter()
             .all(|addr| self.address.iter().any(|net| net.contains(*addr)))
     }
 
     /// Finds [`IpNetwork`] containing given [`IpAddr`]
+    #[must_use]
     pub fn get_containing_network(&self, addr: IpAddr) -> Option<IpNetwork> {
         self.address.iter().find(|net| net.contains(addr)).copied()
     }
@@ -1273,6 +1275,7 @@ impl WireguardNetwork<Id> {
         Ok(())
     }
 
+    #[must_use]
     pub fn mfa_enabled(&self) -> bool {
         match self.location_mfa_mode {
             LocationMfaMode::Internal | LocationMfaMode::External => true,

crates/defguard_core/src/enterprise/activity_log_stream/activity_log_stream_manager.rs

@@ -66,13 +66,12 @@ pub async fn run_activity_log_stream_manager(
                                 cancel_token.clone(),
                             ));
                         }
-                    };
+                    }
                 } else {
                     error!(
                         "Failed to deserialize config for activity log stream {0}",
                         &activity_log_stream.name
                     );
-                    continue;
                 }
             }
         } else {
@@ -87,7 +86,7 @@ pub async fn run_activity_log_stream_manager(
         // - streaming task terminated early
         loop {
             tokio::select! {
-                _ = notification.notified() => {
+                () = notification.notified() => {
                     info!(
                         "Activity log stream manager configuration refresh notification received, reloading streaming tasks."
                     );

crates/defguard_core/src/enterprise/activity_log_stream/http_stream.rs

@@ -38,7 +38,7 @@ pub(super) async fn run_http_stream_task(
     };
     loop {
         tokio::select! {
-            _ = cancel_token.cancelled() => {
+            () = cancel_token.cancelled() => {
                 debug!("Activity log stream ({stream_name}) task received cancellation signal.");
                 break;
             },

crates/defguard_core/src/enterprise/ldap/mod.rs

@@ -389,7 +389,6 @@ impl LDAPConnection {
                 );
                 self.sync_user_data(user, pool).await?;
                 debug!("User {user} data synchronized");
-                continue;
             }
         }