Skip to content

add location type, fwmark, mtu columns to locations table #2147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
j-chmielewski merged 2 commits into from
Feb 27, 2026
Merged

add location type, fwmark, mtu columns to locations table #2147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be31efd
add location type, fwmark, mtu columns to locations table
j-chmielewski Feb 27, 2026
4334aef
add minSize to locations table
j-chmielewski Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 46 additions & 2 deletions web/src/pages/LocationsPage/components/LocationsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export const LocationsTable = () => {
const columns = useMemo(
() => [
columnHelper.accessor('name', {
header: 'Location name',
header: 'Name',
meta: {
flex: true,
},
Expand Down Expand Up @@ -118,7 +118,7 @@ export const LocationsTable = () => {
header: 'Firewall',
size: 76,
cell: (info) => (
<TableCell className="cell-acl-enabled">
<TableCell className="cell-with-check-icons">
{info.getValue() ? (
<Icon icon="check-filled" staticColor={ThemeVariable.FgSuccess} />
) : (
Expand Down Expand Up @@ -158,6 +158,50 @@ export const LocationsTable = () => {
}
},
}),
columnHelper.accessor('service_location_mode', {
header: 'Service location',
minSize: 100,
cell: (info) => {
switch (info.getValue()) {
case 'disabled':
return (
<TableCell className="cell-with-check-icons">
<Icon icon="disabled" />
</TableCell>
);
case 'prelogon':
return (
<TableCell>
<span>Pre-logon</span>
</TableCell>
);
case 'alwayson':
return (
<TableCell>
<span>Always</span>
</TableCell>
);
}
},
}),
columnHelper.accessor('fwmark', {
header: 'FWMark',
minSize: 100,
cell: (info) => (
<TableCell>
<span>0x{info.getValue().toString(16)}</span>
</TableCell>
),
}),
columnHelper.accessor('mtu', {
header: 'MTU',
minSize: 100,
cell: (info) => (
<TableCell>
<span>{info.getValue()}</span>
</TableCell>
),
}),
columnHelper.accessor('allowed_groups', {
header: 'Allowed groups',
size: 500,
Expand Down
2 changes: 1 addition & 1 deletion web/src/pages/LocationsPage/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#locations-page {
.table {
.cell-acl-enabled {
.cell-with-check-icons {
.icon[data-kind='disabled'] path {
fill: var(--fg-critical);
}
Expand Down
Loading