Skip to content

Add snackbars to all settings pages, fix form state in client behavio… #2290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
filipslezaklab merged 2 commits into from
Mar 11, 2026
Merged

Add snackbars to all settings pages, fix form state in client behavio… #2290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e756c91
add snackbars to all settings pages, fix form state in client behavio…
j-chmielewski Mar 11, 2026
7b48382
lint fixes
j-chmielewski Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions web/src/pages/settings/SettingsClientPage/SettingsClientPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import api from '../../../shared/api/api';
import { businessBadgeProps } from '../../../shared/components/badges/BusinessBadge';
import { Controls } from '../../../shared/components/Controls/Controls';
import { Button } from '../../../shared/defguard-ui/components/Button/Button';
import { Snackbar } from '../../../shared/defguard-ui/providers/snackbar/snackbar';
import { useAppForm } from '../../../shared/form';
import { formChangeLogic } from '../../../shared/formLogic';
import { openModal } from '../../../shared/hooks/modalControls/modalsSubjects';
Expand Down Expand Up @@ -78,6 +79,12 @@ const Content = () => {
meta: {
invalidate: [['enterprise_settings'], ['settings']],
},
onSuccess: () => {
Snackbar.success(m.settings_msg_saved());
},
onError: () => {
Snackbar.error(m.settings_msg_save_failed());
},
});

const defaultValues = useMemo((): FormFields => {
Expand Down Expand Up @@ -105,6 +112,7 @@ const Content = () => {
const { result } = canUseBusinessFeature(licenseInfo);
if (result) {
await patchSettings(value);
form.reset(value);
} else {
openModal(ModalName.LicenseExpired, {
licenseTier: licenseInfo?.tier,
Expand Down
7 changes: 7 additions & 0 deletions web/src/pages/settings/SettingsEnrollmentPage/SettingsEnrollmentPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { SettingsHeader } from '../../../shared/components/SettingsHeader/Settin
import { SettingsLayout } from '../../../shared/components/SettingsLayout/SettingsLayout';
import { Button } from '../../../shared/defguard-ui/components/Button/Button';
import { SizedBox } from '../../../shared/defguard-ui/components/SizedBox/SizedBox';
import { Snackbar } from '../../../shared/defguard-ui/providers/snackbar/snackbar';
import { ThemeSpacing } from '../../../shared/defguard-ui/types';
import { isPresent } from '../../../shared/defguard-ui/utils/isPresent';
import { useAppForm } from '../../../shared/form';
Expand Down Expand Up @@ -87,6 +88,12 @@ const Content = ({ settings }: { settings: Settings }) => {
meta: {
invalidate: ['settings'],
},
onSuccess: () => {
Snackbar.success(m.settings_msg_saved());
},
onError: () => {
Snackbar.error(m.settings_msg_save_failed());
},
});

const defaultValues = useMemo(
Expand Down
10 changes: 9 additions & 1 deletion web/src/pages/settings/SettingsGatewayNotificationsPage/SettingsGatewayNotificationsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import { Button } from '../../../shared/defguard-ui/components/Button/Button';
import { Fold } from '../../../shared/defguard-ui/components/Fold/Fold';
import { InfoBanner } from '../../../shared/defguard-ui/components/InfoBanner/InfoBanner';
import { SizedBox } from '../../../shared/defguard-ui/components/SizedBox/SizedBox';
import { Snackbar } from '../../../shared/defguard-ui/providers/snackbar/snackbar';
import { ThemeSpacing } from '../../../shared/defguard-ui/types';
import { isPresent } from '../../../shared/defguard-ui/utils/isPresent';
import { useAppForm } from '../../../shared/form';
Expand Down Expand Up @@ -83,6 +84,12 @@ const Content = ({ settings }: { settings: SettingsGatewayNotifications }) => {
meta: {
invalidate: ['settings'],
},
onSuccess: () => {
Snackbar.success(m.settings_msg_saved());
},
onError: () => {
Snackbar.error(m.settings_msg_save_failed());
},
});

const form = useAppForm({
Expand All @@ -93,7 +100,8 @@ const Content = ({ settings }: { settings: SettingsGatewayNotifications }) => {
onChange: formSchema,
},
onSubmit: async ({ value }) => {
mutateAsync(value);
await mutateAsync(value);
form.reset(value);
},
});

Expand Down
Loading