Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions web/messages/en/modal.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
"modal_delete_location_body": "Deleting location {name} will also delete related gateways. This action cannot be undone.",
"modal_delete_network_device_title": "Delete device",
"modal_delete_network_device_body": "Are you sure you want to delete this device? This action cannot be undone.",
"modal_delete_user_device_title": "Delete device",
"modal_delete_user_device_body": "Are you sure you want to delete the {name} device? This action cannot be undone.",
"modal_delete_openid_client_title": "Delete application",
"modal_delete_openid_client_body": "Are you sure you want to delete this application? This action cannot be undone.",
"modal_delete_acl_alias_title": "Delete alias",
Expand Down
2 changes: 2 additions & 0 deletions web/messages/en/profile.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@
"profile_devices_menu_show_config": "Show configuration",
"profile_devices_menu_ip_settings": "Device IP settings",
"profile_devices_tooltip_biometric": "Biometric is enabled for this device",
"user_device_delete_success": "Device deleted",
"user_device_delete_failed": "Failed to delete device",
"profile_auth_keys_no_data_title": "You don't have any added keys.",
"profile_auth_keys_no_data_subtitle": "To add one, click the button below",
"profile_auth_keys_no_data_cta": "Add new key",
Expand Down
19 changes: 10 additions & 9 deletions web/src/pages/UsersOverviewPage/UsersTable.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -434,13 +434,6 @@ export const UsersTable = () => {
[],
);

const { mutate: deleteDevice } = useMutation({
mutationFn: api.device.deleteDevice,
meta: {
invalidate: [['user-overview'], ['user'], ['network']],
},
});

const makeDeviceRowMenu = useCallback(
(
device: Device,
Expand Down Expand Up @@ -492,15 +485,23 @@ export const UsersTable = () => {
{
text: m.controls_delete(),
onClick: () => {
deleteDevice(device.id);
openModal(ModalName.ConfirmAction, {
title: m.modal_delete_user_device_title(),
contentMd: m.modal_delete_user_device_body({ name: device.name }),
actionPromise: () => api.device.deleteDevice(device.id),
invalidateKeys: [['user-overview'], ['user'], ['network']],
submitProps: { text: m.controls_delete(), variant: 'critical' },
onSuccess: () => Snackbar.default(m.user_device_delete_success()),
onError: () => Snackbar.error(m.user_device_delete_failed()),
});
},
variant: 'danger',
icon: 'delete',
},
],
},
],
[deleteDevice],
[],
);

const renderExpanded = useCallback(
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import './style.scss';
import { useMutation } from '@tanstack/react-query';
import {
createColumnHelper,
getCoreRowModel,
Expand Down Expand Up @@ -112,13 +111,6 @@ const DevicesTable = ({ rowData }: { rowData: RowData[] }) => {
[devices, user, info.network_present],
);

const { mutate: deleteDevice } = useMutation({
mutationFn: api.device.deleteDevice,
meta: {
invalidate: [['user-overview'], ['user', username], ['network']],
},
});

const makeRowMenu = useCallback(
(row: RowData): MenuItemsGroup[] => {
const items: MenuItemProps[] = [
Expand Down Expand Up @@ -169,15 +161,23 @@ const DevicesTable = ({ rowData }: { rowData: RowData[] }) => {
{
text: m.controls_delete(),
onClick: () => {
deleteDevice(row.id);
openModal(ModalName.ConfirmAction, {
title: m.modal_delete_user_device_title(),
contentMd: m.modal_delete_user_device_body({ name: row.name }),
actionPromise: () => api.device.deleteDevice(row.id),
invalidateKeys: [['user-overview'], ['user', username], ['network']],
submitProps: { text: m.controls_delete(), variant: 'critical' },
onSuccess: () => Snackbar.default(m.user_device_delete_success()),
onError: () => Snackbar.error(m.user_device_delete_failed()),
});
},
variant: 'danger',
icon: 'delete',
},
);
return [{ items }];
},
[reservedNames, username, deleteDevice, isAdmin],
[reservedNames, username, isAdmin],
);

const tableColumns = useMemo(
Expand Down Expand Up @@ -296,6 +296,7 @@ const DevicesTable = ({ rowData }: { rowData: RowData[] }) => {
},
columns: tableColumns,
data: rowData,
getRowId: (row) => String(row.id),
getCoreRowModel: getCoreRowModel(),
getSortedRowModel: getSortedRowModel(),
getExpandedRowModel: getExpandedRowModel(),
Expand Down
Loading