Send Gateway reconnect email#2398
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends gateway email notification behavior by adding a “gateway reconnected” notification (with an inactivity threshold), and adjusts build-time version metadata generation in defguard_common.
Changes:
- Add reconnect email notification flow in
GatewayHandlerand trigger it on successful gateway connection timestamp update. - Update mail handler API for reconnect notifications to require a non-optional gateway name.
- Simplify
defguard_commonbuild metadata generation by removing branch emission and adjustingvergen-git2dependency usage.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| crates/defguard_gateway_manager/src/handler.rs | Adds reconnect notification logic and refines disconnect notification gating; triggers reconnect email after touch_connected. |
| crates/defguard_core/src/handlers/mail.rs | Changes send_gateway_reconnected_email to take gateway_name: String (non-optional). |
| crates/defguard_common/Cargo.toml | Simplifies vergen-git2 build-dependency declaration. |
| crates/defguard_common/build.rs | Stops emitting git branch metadata; emits SHA only. |
| Cargo.lock | Updates lockfile to reflect dependency graph changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
t-aleksander
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2359