Add missing disable confirmations#2404
Merged
Merged
Conversation
filipslezaklab
approved these changes
Mar 18, 2026
There was a problem hiding this comment.
Pull request overview
This PR addresses DefGuard issue #2304 by adding missing confirmation dialogs (and related success/error feedback) for destructive or security-sensitive UI actions, primarily around deletes and MFA disablement in the web UI.
Changes:
- Replaced immediate mutations with
ConfirmActionmodal flows for deleting authorized apps, auth keys, API tokens, edges, groups, and passkeys; and for disabling MFA methods (email/TOTP/all/passkeys) in the user profile. - Added confirmation + feedback for enabling/disabling user accounts in the users table, and added success/error snackbars for some delete actions.
- Extended English message catalogs with new modal copy and snackbar strings.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| web/src/pages/user-profile/UserProfilePage/tabs/ProfileDetailsTab/components/ProfileAuthorizedApps/ProfileAuthorizedApps.tsx | Adds confirmation modal + snackbar feedback for removing an authorized app |
| web/src/pages/user-profile/UserProfilePage/tabs/ProfileDetailsTab/components/ProfileAuthCard/ProfileAuthCard.tsx | Adds confirmation modals + snackbars for disabling MFA methods and passkeys |
| web/src/pages/user-profile/UserProfilePage/tabs/ProfileAuthKeysTab/ProfileAuthKeysTable.tsx | Adds confirmation modal + snackbar feedback for deleting auth keys |
| web/src/pages/user-profile/UserProfilePage/tabs/ProfileApiTokensTab/components/ProfileApiTokensTable/ProfileApiTokensTable.tsx | Adds confirmation modal + snackbar feedback for deleting API tokens |
| web/src/pages/settings/SettingsActivityLogStreamingPage/ActivityLogStreamTable.tsx | Adds success snackbar for deleting a log streaming destination |
| web/src/pages/UsersOverviewPage/UsersTable.tsx | Adds confirmation + snackbars for enable/disable account; adds snackbars for delete user |
| web/src/pages/GroupsPage/components/GroupsTable/GroupsTable.tsx | Adds success/error snackbars after group deletion |
| web/src/pages/EdgesPage/EdgesTable.tsx | Adds success/error snackbars after edge deletion |
| web/messages/en/users.json | Adds strings for account enable/disable confirmations + snackbars; tweaks MFA-disable copy |
| web/messages/en/settings.json | Adds success message for activity log stream deletion |
| web/messages/en/modal.json | Consolidates authorized-app delete copy; adds many new modal + snackbar strings for MFA/key/token actions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "modal_delete_authorized_app_title": "Delete authorized app", | ||
| "modal_delete_authorized_app_content_1": "Are you sure you want to remove this application? If you do, you won't be able to use it to log in with defguard anymore.", | ||
| "modal_delete_authorized_app_content_2": "Please note: until you log out from this application, it will remain signed in with DefGuard.", | ||
| "modal_delete_authorized_app": "Are you sure you want to remove this application? This action cannot be undone.", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Involves: #2304