Skip to content

Autoadoption logs#2416

Merged
j-chmielewski merged 5 commits into
devfrom
autoadoption-logs
Mar 23, 2026
Merged

Autoadoption logs#2416
j-chmielewski merged 5 commits into
devfrom
autoadoption-logs

Conversation

@j-chmielewski
Copy link
Copy Markdown
Contributor

@j-chmielewski j-chmielewski commented Mar 20, 2026

  • add scoped log buffering to auto-adoption attempts
  • merge persisted failure logs from Core and component streams
  • use existing wizard.auto_adoption_state.adoption_result[component].logs persistence
  • enable debug-level tracing for defguard_setup::auto_adoption
  • cleanup previous logs on successful adoption

- add scoped setup-log buffering to auto-adoption attempts
- merge persisted failure logs from Core and component streams
- use existing wizard.auto_adoption_state.adoption_result[component].logs persistence
- enable debug-level tracing for defguard_setup::auto_adoption
@j-chmielewski j-chmielewski marked this pull request as ready for review March 20, 2026 13:22
@j-chmielewski j-chmielewski requested a review from Copilot March 20, 2026 13:22
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds scoped tracing log buffering to auto-adoption attempts so that actionable Core + component-stream logs can be persisted into the existing wizard.auto_adoption_state.adoption_result[component].logs on failures, and enables debug-level tracing for the auto-adoption module.

Changes:

  • Scoped Core tracing capture via scope_setup_logs, and merged Core + component stream logs on failures.
  • Persist failure logs per component while avoiding persisting logs for successful adoptions.
  • Added integration tests asserting per-component failure logs are persisted and include Core debug lines; enabled defguard_setup::auto_adoption=debug in the main binary log filter.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
crates/defguard_setup/src/auto_adoption.rs Introduces scoped Core log buffering and merges Core + component logs into persisted failure results.
crates/defguard_setup/tests/auto_adoption_wizard.rs Adds tests validating that per-component failure logs are persisted and include Core debug output.
crates/defguard_setup/Cargo.toml Adds tracing-subscriber as a dev-dependency for the new tests’ tracing initialization.
crates/defguard/src/main.rs Extends the runtime log filter to enable debug logs for defguard_setup::auto_adoption.
Cargo.lock Locks the additional dev dependency.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread crates/defguard_setup/src/auto_adoption.rs
Comment thread crates/defguard_setup/src/auto_adoption.rs
@j-chmielewski j-chmielewski merged commit 263026c into dev Mar 23, 2026
3 checks passed
@j-chmielewski j-chmielewski deleted the autoadoption-logs branch March 23, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants