Skip to content

fix: verify mfa status during openid authorization#641

Merged
t-aleksander merged 2 commits into
devfrom
fix-oid-mfa
Jun 11, 2024
Merged

fix: verify mfa status during openid authorization#641
t-aleksander merged 2 commits into
devfrom
fix-oid-mfa

Conversation

@t-aleksander
Copy link
Copy Markdown
Contributor

@t-aleksander t-aleksander commented Jun 11, 2024

📖 Description

Previously only the session existence and its expiration status was checked during the openid authorization, which is not enough, as the session is created before the MFA verification takes place.

🛠️ Dev Branch Merge Checklist:

Documentation

  • If testing requires changes in the environment or deployment, please update the documentation (https://defguard.gitbook.io) first and attach the link to the documentation section in this pool request
  • I have commented on my code, particularly in hard-to-understand areas

Testing

  • I have prepared end-to-end tests for all new functionalities
  • I have performed end-to-end tests manually and they work
  • New and existing unit tests pass locally with my changes

Deployment

  • If deployment is affected I have made corresponding/required changes to deployment (Docker, Kubernetes, one-line install)

🏚️ Main Branch Merge Checklist:

Testing

  • I have merged my changes before to dev and the dev checklist is done
  • I have tested all functionalities on the dev instance and they work

Documentation

  • I have made corresponding changes to the user & admin documentation and added new features documentation with screenshots for users/admins

@t-aleksander t-aleksander self-assigned this Jun 11, 2024
@t-aleksander t-aleksander merged commit c92960e into dev Jun 11, 2024
@t-aleksander t-aleksander deleted the fix-oid-mfa branch June 11, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

User can bypass MFA process for OpenID auth when app is already accepted for the account.

2 participants