Implemented Gunpowder#27
Open
g3ksmithington wants to merge 1 commit into
Open
Conversation
Owner
|
Going to move this into a new issue.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to check out the process for writing mods and I stumbled upon your mod while perusing GitHub repositories!
I saw that you wanted to implement gunpowder so I went ahead and did it!
According to WikiHow (https://www.wikihow.com/Make-Gunpowder) gunpowder is 74.8% saltpeter, 13.3% charcoal and 11.9% elemental Sulphur. I added sulphur as a new item (added it to spawn locations, but lazily: registerAsLoot(iReg, 4, "toolstore", "all");), created a recipe for saltpeter from sourcing coldpacks (since that is a source) using a mortar and pestle, and then a recipe for gunpowder that includes your already implemented woodash! I was also considering using your drying mechanism for getting Saltpeter from Coldpacks, but went with mortal and pestle instead.
I haven't tested it yet, but looking through your code I think I've implemented it correctly. I'll be able to test it in game later on today.