Skip to content

Conversation

@CNBoland
Copy link
Contributor

Please fill in this template.

  • [ x ] Use a meaningful title for the pull request. Include the name of the package modified.
  • [ x ] Test the change in your own code. (Compile and run.)
  • [ x ] Add or edit tests to reflect the change. (Run with npm test.)
  • [ x ] Follow the advice from the readme.
  • [ x ] Avoid common mistakes.
  • [ x ] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot typescript-bot added Awaiting reviewer feedback Author is Owner The author of this PR is a listed owner of the package. labels May 22, 2018
@typescript-bot
Copy link
Contributor

typescript-bot commented May 22, 2018

@CNBoland Thank you for submitting this PR!

🔔 @Silver-Connection @omidkrad @pragmatrix - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

Since you're a listed owner and the build passed, this PR is fast-tracked. A maintainer will merge shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@DanielRosenwasser DanielRosenwasser merged commit 883ca8a into DefinitelyTyped:master May 23, 2018
@DanielRosenwasser
Copy link
Member

Thanks!

@CNBoland CNBoland deleted the master_explicit_this branch May 23, 2018 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author is Owner The author of this PR is a listed owner of the package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants