removed es6-promise dependency from react-bootstrap#6227
Merged
vvakame merged 1 commit intoDefinitelyTyped:masterfrom Oct 12, 2015
Merged
removed es6-promise dependency from react-bootstrap#6227vvakame merged 1 commit intoDefinitelyTyped:masterfrom
vvakame merged 1 commit intoDefinitelyTyped:masterfrom
Conversation
vvakame
added a commit
that referenced
this pull request
Oct 12, 2015
removed es6-promise dependency from react-bootstrap
Member
|
thanks mate! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React-Bootstrap package right now unnecessarily uses es6-promise module. This makes it incompatible in projects which use other Promise libraries such as Bluebird. No instance of Promise is used in react-bootstrap so removing the reference from teh module.