You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@DelSkayn please have a look. I had to bump MSRV to 1.77 because some features requires minimum 1.77. Also bindings generate bool on some platforms and i32 on others, hence the required casting.
Weird that the MSRV didn't fail before. If offset_of was introduced in 1.77 it shouldn't have compiled on 1.65..
I didn't fail because that code was feature gated
I would like to avoid committing the lock file. I think it is still best to ensure rquickjs is tested against the latest dependencies if possible. The linked blog post says that they do not have a default recommendation not that they recommend against not committing the lockfile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation panics if object is not a typed array due to bad unwrap. This PR fixes that.
Also fixes #416