Skip to content

fix conversation filter logic to prevent empty filter state #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spashii merged 1 commit into from
Apr 9, 2025
Merged

fix conversation filter logic to prevent empty filter state #105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions echo/frontend/src/components/conversation/ConversationAccordion.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,19 +472,21 @@ export const ConversationAccordion = ({ projectId }: { projectId: string }) => {
return prev.filter((f) => f !== filterValue);
}

// Case 1.5: if no filters are active, toggle all filters
if (prev.length === 1) {
return allFilterValues;
// Case 2: If the filter is inactive, toggle it on
if (!isActive) {
return [...prev, filterValue];
}

// Case 2: If the filter is already active, toggle it off
if (isActive) {
// Remove it from active filters
return prev.filter((f) => f !== filterValue);
// Case 3: If the filter is active but it's the only active filter
// don't allow removing the last filter (prevent zero filters)
if (prev.length === 1) {
// Keep at least one filter active
return prev;
}

// Case 3: If the filter is inactive, toggle it on
return [...prev, filterValue];
// Case 4: If the filter is active and there are other active filters,
// toggle it off
return prev.filter((f) => f !== filterValue);
});
};

Expand Down